1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.
  2. Dismiss Notice
  3. What happens when the XF 2.0 is out? See the discussion here: http://www.sonnb.com/threads/what-happens-when-xf-2-0-is-out.1146/
    Dismiss Notice

Fixed Php 7.2 Support / Fixes

Discussion in 'XenGallery' started by oNdsen, Sep 28, 2018.

  1. oNdsen

    oNdsen Authorized Member Authorized

    Fix:
    library/sonnb/XenGallery/Model/Gallery.php
    Replace Line 223
    PHP:
    while(list($key,$value) = each($aPattern))
    with
    PHP:
    foreach($aPattern AS $key => $value)


    Fix:
    library/sonnb/XenGallery/WidgetRenderer/Album.php
    Replace Line 269
    PHP:
    array_walk($userIdscreate_function('&$userId, $key''$userId = trim($userId);'));
    with
    PHP:
    array_walk($userIds, function(&$userId$key) {
        
    $userId trim($userId);
    });
     
    sonnb, RobinHood and otto like this.
  2. otto

    otto Authorized Member Authorized

    Thanks for sharing this. Its not so fine, the developer not comment this. :(
     
  3. RobinHood

    RobinHood Authorized Member Authorized

    Thanks for the fix
     
  4. sonnb

    sonnb Administrator Staff Member

    I did not realize this thread. Thanks for your post. I will update to the core code.
     
    zoldos and RobinHood like this.
  5. sonnb

    sonnb Administrator Staff Member

    I am using 7.2.4 but did not get error so I did not aware of this because these functions are still usable. I have just updated to code locally. Thanks @oNdsen
     
    zoldos likes this.
  6. sonnb

    sonnb Administrator Staff Member

    This change was released in 2.6.7.
     
    RobinHood and zoldos like this.
  7. zoldos

    zoldos Authorized Member Authorized

    I'm using PHP 7.3.6 and have no errors that I've seen.
     
  8. sonnb

    sonnb Administrator Staff Member

    Me either. They are deprecated functions but still usable. But adapting is better since they can be removed in later release.
     
    zoldos likes this.
  9. zoldos

    zoldos Authorized Member Authorized

    I went ahead and implemented this patch. I do notice that now I don't have forward/back buttons when viewing videos (viewing pics it works) on Firefox Quantum Developer's Edition. Is this related?
     
  10. sonnb

    sonnb Administrator Staff Member

    It is not related. If you got that it means it is existing since an older release.
     
    zoldos likes this.
  11. zoldos

    zoldos Authorized Member Authorized

    Okay thanks! :D
     
  12. RobinHood

    RobinHood Authorized Member Authorized

    I only saw the errors when I had debug mode enabled. I got a notice at the top of the forum.
     
    sonnb likes this.

Share This Page